Set owner reference for image-builder rolebindings#1590
Merged
dkwon17 merged 2 commits intodevfile:mainfrom Feb 13, 2026
Merged
Set owner reference for image-builder rolebindings#1590dkwon17 merged 2 commits intodevfile:mainfrom
dkwon17 merged 2 commits intodevfile:mainfrom
Conversation
These rolebindings are used for the backup pod for the backup cron job Signed-off-by: dkwon17 <dakwon@redhat.com> Assisted-by: gemini-3-pro-preview
dkwon17
requested review from
akurinnoy,
ibuziuk and
rohanKanojia
as code owners
controllers/backupcronjob/rbac.go
Outdated
Comment on lines
107
to
108
| if err := controllerutil.SetControllerReference(workspace, roleBinding, r.Scheme); err != nil { | ||
| return fmt.Errorf("setting controller reference: %w", err) |
Member
There was a problem hiding this comment.
nit, it might be helpful to include the RoleBinding name/namespace in the wrapped error message.
Suggested change
| if err := controllerutil.SetControllerReference(workspace, roleBinding, r.Scheme); err != nil { | |
| return fmt.Errorf("setting controller reference: %w", err) | |
| if err := controllerutil.SetControllerReference(workspace, roleBinding, r.Scheme); err != nil { | |
| return fmt.Errorf( | |
| "failed to set controller reference for RoleBinding %s/%s: %w", | |
| roleBinding.Namespace, | |
| roleBinding.Name, | |
| err, | |
| ) |
Collaborator
Author
There was a problem hiding this comment.
Sounds good, I applied the change in my latest commit
rohanKanojia
approved these changes
Feb 12, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: dkwon17 <dakwon@redhat.com>
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an owner reference for rolebindings for cleanup when DevWorkspaces are deleted.
What issues does this PR fix or reference?
#1585
Is it tested? How?
I've created a workspace with changes from this PR, and set up the backup cronjob:
I've verified that the devworkspace-image-builder- rolebinding has the owner reference to the DevWorkspace with the same workspace id:
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che